You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ongoing Minor Issue List (SpongeAPI Edition) #1000
Checkstyle issues should not be reported here as those can be more accurately determined by simply running the checkstyle tool. Examples of good issues to report here are misnamed methods/fields, poorly worded javadocs, formatting issues.
As minor things are resolved, comments will be deleted.
https://jd.spongepowered.org/7.2.0/org/spongepowered/api/item/inventory/Inventory.html#offer-org.spongepowered.api.item.inventory.ItemStack- has a very confusing javadoc. It says it returns true if one or more (up to the total number of items in the supplied stack) items were consumed. but the type returned is InventoryTransactionResult.
Not sure if this is intentional, but calling .getRejectedItems() only returns something if the whole stack was rejected, even if it was partially rejected. It seems like theres a mix of mutating the ItemStack and returning a result going on here. I think it should be one or the other.
publicstaticfinalDefaultedRegistryReference<ResourceKeyedValueParameter<ServerWorld>> WORLD = ResourceKeyedValueParameters.key(ResourceKey.sponge("world"));
Please check our [Contribution Guidelines in the Sponge Documentation](https://docs.spongepowered.org/en/contributing/guidelines.html) for more information.
Activity
Add failsafe for CatalogTypes that are DataSerializables.
Rename HumanInventory to PlayerInventory, add utility getters.
Merge pull request #1252 from octo-byte/octobyte/ocd
Fixes JavaDoc issues highlighted in #1000; removes DataSerializable f…
Fix some OCD issues
Add ChunkTicketManager$LoadingTicket#getCompanionData(). Remove two y…
SQUAWK (Add Parrot)
64 remaining items
tyhdefu commentedon Apr 10, 2020
https://jd.spongepowered.org/7.2.0/org/spongepowered/api/item/inventory/Inventory.html#offer-org.spongepowered.api.item.inventory.ItemStack- has a very confusing javadoc. It says it returns
true if one or more (up to the total number of items in the supplied stack) items were consumed.but the type returned is InventoryTransactionResult.Not sure if this is intentional, but calling .getRejectedItems() only returns something if the whole stack was rejected, even if it was partially rejected. It seems like theres a mix of mutating the ItemStack and returning a result going on here. I think it should be one or the other.
[-]Ongoing Minor Issue List (OCD List) Beta Edition[/-][+]Ongoing Minor Issue List (OCD List)[/+][-]Ongoing Minor Issue List (OCD List)[/-][+]Ongoing Minor Issue List (SpongeAPI Edition)[/+]NxDs commentedon Jul 22, 2021
{@link Listener}d instead of {@link Listener}s or {@link Listener}
SpongeAPI/src/main/java/org/spongepowered/api/event/Order.java
Line 28 in e36c95a
Lignium commentedon Aug 7, 2021
Should be
CommandCause commandCauseor justcauseSpongeAPI/src/main/java/org/spongepowered/api/command/parameter/managed/ValueParameter.java
Line 107 in 4f58aeb
SpongeAPI/src/main/java/org/spongepowered/api/command/parameter/managed/ValueParameter.java
Lines 102 to 103 in 4f58aeb
Lignium commentedon Nov 8, 2021
SpongeAPI/src/main/java/org/spongepowered/api/command/parameter/managed/standard/ResourceKeyedValueParameters.java
Lines 465 to 467 in 1a5f417
JonesiBlitz commentedon Nov 9, 2021
Link to docs should be: https://docs.spongepowered.org/stable/en/contributing/guidelines.html
SpongeAPI/CONTRIBUTING.md
Line 5 in 1a5f417
A248 commentedon Aug 20, 2022
The minimum Java version for API 9 is 17, but the README on the api-9 branch states otherwise:
https://github.com/SpongePowered/SpongeAPI/blob/api-9/README.md#prerequisites
DrZoddiak commentedon Sep 18, 2023
This method doesn't need a generic. API 8+
SpongeAPI/src/main/java/org/spongepowered/api/effect/particle/ParticleEffect.java
Lines 167 to 169 in 7946be0