Skip to content

Ongoing Minor Issue List (SpongeAPI Edition) #1000

Open

Description

@Deamon5550

SpongeAPI | Sponge

Checkstyle issues should not be reported here as those can be more accurately determined by simply running the checkstyle tool. Examples of good issues to report here are misnamed methods/fields, poorly worded javadocs, formatting issues.

As minor things are resolved, comments will be deleted.

Activity

  1. added this to the Revision 4.0 milestone on Jan 1, 2016
  2. added 2 commits that reference this issue on Oct 16, 2016
  3. removed this from the Revision 5.0 milestone on Oct 18, 2016
  4. added a commit that references this issue on Nov 29, 2016
  5. added a commit that references this issue on Jun 10, 2017
  6. 64 remaining items

  7. tyhdefu commented on Apr 10, 2020

    @tyhdefu
    Contributor

    https://jd.spongepowered.org/7.2.0/org/spongepowered/api/item/inventory/Inventory.html#offer-org.spongepowered.api.item.inventory.ItemStack- has a very confusing javadoc. It says it returns true if one or more (up to the total number of items in the supplied stack) items were consumed. but the type returned is InventoryTransactionResult.
    Not sure if this is intentional, but calling .getRejectedItems() only returns something if the whole stack was rejected, even if it was partially rejected. It seems like theres a mix of mutating the ItemStack and returning a result going on here. I think it should be one or the other.

  8. changed the title [-]Ongoing Minor Issue List (OCD List) Beta Edition[/-] [+]Ongoing Minor Issue List (OCD List)[/+] on Jun 1, 2021
  9. changed the title [-]Ongoing Minor Issue List (OCD List)[/-] [+]Ongoing Minor Issue List (SpongeAPI Edition)[/+] on Jun 18, 2021
  10. deleted a comment from tyhdefu on Jun 18, 2021
  11. deleted a comment from ejm on Jun 18, 2021
  12. deleted a comment from ejm on Jun 18, 2021
  13. deleted a comment from ejm on Jun 18, 2021
  14. NxDs commented on Jul 22, 2021

    @NxDs

    {@link Listener}d instead of {@link Listener}s or {@link Listener}

    * Order that {@link Listener}d methods may be registered at.

  15. Lignium commented on Aug 7, 2021

    @Lignium
    Contributor

    Should be CommandCause commandCause or just cause

    List<CommandCompletion> complete(CommandCause context, String currentInput);

    * @param context The {@link CommandCause} that contains the parsed
    * arguments

  16. Lignium commented on Nov 8, 2021

    @Lignium
    Contributor

    Returns a {@link WorldProperties}.

    * <p>Returns a {@link WorldProperties}.</p>
    */
    public static final DefaultedRegistryReference<ResourceKeyedValueParameter<ServerWorld>> WORLD = ResourceKeyedValueParameters.key(ResourceKey.sponge("world"));

  17. JonesiBlitz commented on Nov 9, 2021

    @JonesiBlitz

    Link to docs should be: https://docs.spongepowered.org/stable/en/contributing/guidelines.html

    Please check our [Contribution Guidelines in the Sponge Documentation](https://docs.spongepowered.org/en/contributing/guidelines.html) for more information.

  18. A248 commented on Aug 20, 2022

    @A248
    Contributor

    The minimum Java version for API 9 is 17, but the README on the api-9 branch states otherwise:
    https://github.com/SpongePowered/SpongeAPI/blob/api-9/README.md#prerequisites

  19. DrZoddiak commented on Sep 18, 2023

    @DrZoddiak
    Contributor

    This method doesn't need a generic. API 8+

    default <V> Builder scale(Double scale) {
    return this.option(ParticleOptions.SCALE, scale);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions