Skip to content

atime ci: add picrd api key - #7960

Open
tdhock wants to merge 4 commits into
masterfrom
atime-ci-picrd-key
Open

tdhock wants to merge 4 commits into
masterfrom
atime-ci-picrd-key

Conversation

@tdhock

@tdhock tdhock commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

In atime comments we see (Plot image upload to picrd.com failed; download the artifact below to view plots).
This is caused by 401 error from picrd (unauthorized).
Apparently picrd needs an api key now, so I signed up for one, and added it as a repo Actions secret.

Comment thread .github/workflows/performance-tests.yml Outdated
run: |
uploadImage() {
curl --fail --retry 3 -sS -F "file=@$1" -F "visibility=unlisted" https://picrd.com/api/upload | jq -r '.image_url // empty' || true
curl --fail --retry 3 -sS -H "Authorization: Bearer $PICRD_API_KEY" -F "file=@$1" -F "visibility=unlisted" https://picrd.com/api/upload | jq -r '.url // empty' || true

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also new json has url (not image_url)

{"id":"SVUYtiM14sS","url":"https://picrd.com/f/SVUYtiM14sS","raw_url":"https://picrd.com/raw/SVUYtiM14sS.png","filename":"cropped-mmit.png","mime_type":"image/png","size":"189.3 KB","size_bytes":193877,"metadata":{},"expires_at":null,"collection_id":null}

this works locally

(base) hoct2726@dinf-thock-02i:~$ echo '{"id":"SVUYtiM14sS","url":"https://picrd.com/f/SVUYtiM14sS","raw_url":"https://picrd.com/raw/SVUYtiM14sS.png","filename":"cropped-mmit.png","mime_type":"image/png","size":"189.3 KB","size_bytes":193877,"metadata":{},"expires_at":null,"collection_id":null}'|jq -r '.url // empty' || true
https://picrd.com/f/SVUYtiM14sS

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it should be raw_url instead of url

@github-actions

Copy link
Copy Markdown
  • HEAD=atime-ci-picrd-key much slower for melt(list measure.vars, variable.factor=FALSE) improved in #7917
  • HEAD=atime-ci-picrd-key much slower for melt(measure()) improved in #7917
  • HEAD=atime-ci-picrd-key much slower for DT[by,verbose=TRUE] improved in #6296
  • HEAD=atime-ci-picrd-key much faster for fread(colClasses='Date') improved in #6107
  • HEAD=atime-ci-picrd-key faster P<0.001 for DT[by] max regression fixed in #7480

Comparison Plot

Generated via commit d20686a

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 51 seconds
Installing different package versions 8 minutes and 46 seconds
Running and plotting the test cases 3 minutes and 55 seconds

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant