Repository navigation
Conversation
picolibc defines the signal types in signal.h, which clashed with the copies here. Include it as for musl, and add sigevent only when picolibc hides it below POSIX.1b. Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_libcReviewers: @GorrayLi @mysterywolf Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-11-18 03:15 CST)
📝 Review Instructions
|
|
BernardXiong
left a comment
There was a problem hiding this comment.
复核 / Review
复核 482bbe67:新增分支位于 musl 之后、通用回退之前,sys/signal.h:32-55 的 !defined(_POSIX_REALTIME_SIGNALS) && __POSIX_VISIBLE < 199309 与 picolibc signal.h 中 defined(_POSIX_REALTIME_SIGNALS) || __POSIX_VISIBLE >= 199309 正好互补,不会重复定义 SIGEV_*/struct sigevent。union sigval、sigset_t(picolibc __sigset_t 为 unsigned long)和 struct sigaction 由 picolibc 提供,与 posix_signal.c 的位运算及 sa_handler 用法兼容。
The new branch is the exact complement of picolibc's visibility guard; the picolibc-provided union sigval, sigset_t and struct sigaction remain compatible with posix_signal.c. No blocking findings.
作者已在 RH850 qemu-rh850-u2c + picolibc 配置下验证,CI 全绿,本轮未发现需要修改的问题。Approving.
picolibc defines the signal types in its own signal.h, so building with RT_USING_SIGNALS and picolibc fails with redefinition errors in sys/signal.h. Include the picolibc header as is done for musl, and keep struct sigevent and SIGEV_* only when picolibc hides them below POSIX.1b.
Test: RH850 qemu-rh850-u2c with picolibc