Skip to content

[libc][common] Use the picolibc signal.h types in sys/signal.h - #12064

Open
parthitce wants to merge 1 commit into
RT-Thread:masterfrom
linumiz:rh850/fix-signals-picolibc
Open

parthitce wants to merge 1 commit into
RT-Thread:masterfrom
linumiz:rh850/fix-signals-picolibc

Conversation

@parthitce

Copy link
Copy Markdown
Contributor

picolibc defines the signal types in its own signal.h, so building with RT_USING_SIGNALS and picolibc fails with redefinition errors in sys/signal.h. Include the picolibc header as is done for musl, and keep struct sigevent and SIGEV_* only when picolibc hides them below POSIX.1b.

Test: RH850 qemu-rh850-u2c with picolibc

picolibc defines the signal types in signal.h, which clashed with the
copies here. Include it as for musl, and add sigevent only when picolibc
hides it below POSIX.1b.

Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 rh850/fix-signals-picolibc
    Enter PR branch rh850/fix-signals-picolibc in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 rh850/fix-signals-picolibc 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the rh850/fix-signals-picolibc branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/libc/compilers/common/include/sys/signal.h

🏷️ Tag: components_libc

Reviewers: @GorrayLi @mysterywolf

Changed Files (Click to expand)
  • components/libc/compilers/common/include/sys/signal.h

📊 Current Review Status (Last Updated: 2026-11-18 03:15 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

Copy link
Copy Markdown

@BernardXiong BernardXiong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复核 / Review

复核 482bbe67:新增分支位于 musl 之后、通用回退之前,sys/signal.h:32-55 的 !defined(_POSIX_REALTIME_SIGNALS) && __POSIX_VISIBLE < 199309 与 picolibc signal.h 中 defined(_POSIX_REALTIME_SIGNALS) || __POSIX_VISIBLE >= 199309 正好互补,不会重复定义 SIGEV_*/struct sigevent。union sigval、sigset_t(picolibc __sigset_t 为 unsigned long)和 struct sigaction 由 picolibc 提供,与 posix_signal.c 的位运算及 sa_handler 用法兼容。

The new branch is the exact complement of picolibc's visibility guard; the picolibc-provided union sigval, sigset_t and struct sigaction remain compatible with posix_signal.c. No blocking findings.

作者已在 RH850 qemu-rh850-u2c + picolibc 配置下验证,CI 全绿,本轮未发现需要修改的问题。Approving.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants