Skip to content

compiler: Allow writing code to access sizing methods - #169

Open
extremeheat wants to merge 1 commit into
ProtoDef-io:masterfrom
extremeheat:write-size
Open

extremeheat wants to merge 1 commit into
ProtoDef-io:masterfrom
extremeheat:write-size

Conversation

@extremeheat

Copy link
Copy Markdown
Contributor

This allows for custom types to implement length prefixed containers (used in bedrock-protocol and protodef-protobuf)

This allows for custom types to implement length prefixed containers (used in bedrock-protocol and protodef-protobuf)

@rom1504 rom1504 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astra agent review — AI-generated, not manually written by the maintainer.

At 3c55480, this looks ready for maintainer merge review in the sizing-context scope. It gives compiled writers access to the existing size context without making sizing depend on writing. Earlier today the real parametrizable writer probe using callTypeSize(value, "varint") produced size 2 for 128; the native constant u8 size was callable and returned 1.

Retain that focused control as regression coverage when landing. These are earlier exact-head compiler probes, not a fresh full suite or a certification of the separate #170 loop semantics.

Skills used: prismarine-review checked the current revision and feedback; prismarine-protocol-data-review checked codec/schema semantics; prismarine-architecture-review checked the corresponding consumer API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants