Repository navigation
Model review for PRs to .github: self-review rule R-self and scripted setup - #37
Conversation
PRs to .github run claude-review.yml from main, so R1 (bound to the release SHA) refuses their token. Analyze now picks a second rule, R-self, only when the runner's GITHUB_REPOSITORY_ID is .github and GITHUB_EVENT_NAME is pull_request_target. Every other run keeps R1. The R-self ID is all zeros until the owner creates the rule, so those runs still fail with "federation not configured", never a pass. make self-review-plan / self-review-setup create the workspace, the service account membership and the rule (find first, create only what is missing, never edit), read them back, and write the rule ID into analyze.py. They reuse release.py's ephemeral ant login and exit rules (run_guarded, Console.call, check_ant per resource). The workspace spend limit stays manual: ant has no command for it. The release tool still touches only R1; tests prove it, and its rule test refuses a rule bound to a branch ref such as R-self. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le and file checks - Direct pull_request_target runs carry job_workflow_ref/job_workflow_sha: recorded V3 direct-run claims (run 40259047420) as a test fixture, and run 43631842435 passed the local job_workflow_sha check on .github. Spec records the evidence; tests use the recorded claim set. - Setup reads and checks everything before any write. List output must be one item per JSONL line or a complete data page, and each item needs its fields, else it refuses before a create or add. - The service account must have role workspace_developer, for an existing member and after an add. - analyze.py is written atomically, only when it did not change during the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🔴 Comms down: the Claude of Duty review did not completeMission: Review the code. Protect the branch. Deploy the future. Caution The Review, Security and Supply chain reviews did not run, so this PR could not be judged. No waiver can clear this.
Run 43635344322, attempt 1 for head Claude of Duty never approves a PR. A human reviewer gives the final approval. 📋 Full review record: reasons, checks, signals, finding details, model summaries, token usageReviewed snapshot
Reasons the gate failed
No waiver line is shown. At least one reason cannot be waived, so a waiver would not change the result. Checks (code, no model)
Signals (context only, never block)
Dependency changes None. Finding details
Blocking is decided by code from category and severity, never by the model. A finding in a blocking category blocks only at high or critical severity. No findings from the passes that ran. The Review, Security, Supply chain pass did not run, so this is not a clean result. Model summaries
Token usage No token usage was recorded for any pass. |
Closes #36.
PRs to
.githubget no model review today: the file runs there as a normalpull_request_targetworkflow frommain, and rule R1 accepts only the release SHA. This adds rule R-self for that case only.What changed
GITHUB_REPOSITORY_IDis.githubandGITHUB_EVENT_NAMEispull_request_target. Everything else keeps R1. R-self ships as an all-zero placeholder, so.githubruns still fail closed until the rule exists.make self-review-plan/make self-review-setup: ephemeralantlogin, cleared on every exit (shared with the release tool). Reads and checks everything before any write, refuses unknown response shapes and wrong member roles, creates the workspace, adds the service account asworkspace_developer, creates the rule, reads it back, then writes the rule ID intoanalyze.pyatomically (refuses if the file changed during the run).Owner steps after merge
make self-review-plan(read-only).make self-review-setup.claude-review-self-review(anthas no command for it).analyze.pychange in a new PR.Testing
cd review && uv run pytest tests/unit: 3409 passed, 2 deselected.Not checked
antresponse shapes (the tool refuses unknown shapes).job_workflow_refvalue of a direct.githubpull_request_targetrun. Evidence shows the claim exists; the first R-self run shows its value.🤖 Generated with Claude Code