Skip to content

Add JUnit Tests and CI #4

Open
Open

Description

@kevinthegreat1

This repo seems to lack automatic tests and CI.

It has the kotest library but doesn't seem to use it? Would the maintainers be open to a pr that replaces kotest with JUnit and adds CI?

Great library btw, thanks for your work!

Activity

  1. lineargraph commented on May 2, 2024

    @lineargraph
    Member

    Hey!

    Thanks for your interest. I originally intended for CI to be ran on this, but I found it difficult to decide on a way to use the repo. Ideally I would test against the entire repo, and that is an ever evolving piece of data that changes all the time. Finding a balance between just copying individual JSON files into this repo to test just those and running against the entire repo and potentially breaking when there is an update is something I have not yet solved.

    Either one of those approaches would be appreciated tho.

  2. kevinthegreat1 commented on May 3, 2024

    @kevinthegreat1
    ContributorAuthor

    Hi,

    Thanks for your reply. I can run against the entire repo with GitHub Actions. I'll submit a pr with that and JUnit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions