Repository navigation
Conversation
…ster A canary-only or canary-less RolloutRun without a batch strategy panics on obj.Spec.Batch.Batches in findWorkloadsCrossCluster, which runs on every reconcile. Return empty workload sets when Spec.Batch is nil. Co-Authored-By: Claude <noreply@anthropic.com>
Previously ValidateRolloutRunBatchStrategy returned nil when spec.batch was unset, so a RolloutRun with neither canary nor batch passed validation and later hit a nil dereference in the controller. Nil batch is now reported as a required-field error along with the empty batches case, and the test expectations are updated accordingly. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ster
A canary-only or canary-less RolloutRun without a batch strategy panics on obj.Spec.Batch.Batches in findWorkloadsCrossCluster, which runs on every reconcile. Return empty workload sets when Spec.Batch is nil.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.