Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ public enum MariaDbVersion implements Version {
Feature.jdbcParameter,
Feature.jdbcNamedParameter, // expressions
Feature.exprLike, // https://mariadb.com/kb/en/select/
Feature.select,
Feature.select, // https://mariadb.com/kb/en/selectinto/
Feature.selectInto,
Feature.selectGroupBy, Feature.function,
Feature.selectHaving,
Feature.limit, Feature.limitOffset, Feature.offset, Feature.offsetParam,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ public enum MySqlVersion implements Version {
Feature.jdbcParameter,
Feature.jdbcNamedParameter, // expressions
Feature.exprLike, // https://dev.mysql.com/doc/refman/8.0/en/select.html
Feature.select,
Feature.select, // https://dev.mysql.com/doc/refman/8.0/en/select-into.html
Feature.selectInto,
Feature.selectGroupBy, Feature.selectHaving,
Feature.limit, Feature.limitOffset, Feature.offset, Feature.offsetParam,
Feature.orderBy,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ public <S> Void visit(PlainSelect plainSelect, S context) {
|| modifier == MySqlSelectModifier.SQL_BUFFER_RESULT),
Feature.mysqlSelectModifiers);
validateOptionalFeature(c, plainSelect.getIntoTables(), Feature.selectInto);
validateOptionalFeature(c, plainSelect.getIntoTempTable(), Feature.selectInto);
validateOptionalFeature(c, plainSelect.getMySqlSelectIntoClause(),
Feature.selectInto);
validateOptionalFeature(c, plainSelect.getKsqlWindow(), Feature.kSqlWindow);
validateFeature(c,
isNotEmpty(plainSelect.getOrderByElements()) && plainSelect.isOracleSiblings(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,22 @@ public void testValidationMySqlSelectModifiers() {
validateNotSupported(sql, 1, 1, DatabaseType.POSTGRESQL, Feature.mysqlSelectModifiers);
}

@ParameterizedTest
@ValueSource(strings = {"SELECT a INTO OUTFILE '/tmp/a.txt' FROM t",
"SELECT a FROM t INTO OUTFILE '/tmp/a.txt'",
"SELECT a FROM t INTO DUMPFILE '/tmp/a.bin'",
"SELECT a FROM t WHERE a IN (SELECT b FROM u INTO OUTFILE '/tmp/b.txt')",
"SELECT * FROM t INTO TEMP x"})
public void testValidationSelectIntoNotAllowed(String sql) {
validateNotAllowed(sql, 1, 1, FeaturesAllowed.SELECT, Feature.selectInto);
}

@Test
public void testValidationMySqlSelectIntoOutfile() {
String sql = "SELECT a FROM t INTO OUTFILE '/tmp/a.txt'";
validateNoErrors(sql, 1, DatabaseType.MYSQL, DatabaseType.MARIADB);
}

@Test
public void testValidationSelectDistinct() throws JSQLParserException {
String sql = "SELECT DISTINCT a, b FROM tab";
Expand Down
Loading