Repository navigation
feat: offer an opt-in Expo UI Bottom Sheet solution over gorhom - #3940
Open
frankcalise wants to merge 2 commits into
Open
frankcalise wants to merge 2 commits into
frankcalise wants to merge 2 commits into
Conversation
Add an optional Expo attachment-picker entry point and component override. Retain Gorhom as the SDK default and enable the adapter in ExpoMessaging. Coordinate modal dismissal and add focused tests and recorded UI flows. Include the approved Expo 58.0.9 demo patch for the Xcode 27 launch fix. Native builds, focused tests, typechecks, and the iOS open/close replay pass. Web coverage, modal handoffs, and Android rapid-reopen timing remain follow-up work.
isekovanic
self-requested a review
November 5, 2026 14:54
Contributor
|
Hi @frankcalise ! Thank you for the contribution. Just a heads up, I will be able to take a more serious look at this next week, as tomorrow we are going to be releasing V10. It will likely need to be ported there since I probably won't feel comfortable releasing this on V9 (at least not immediately). I'll let you know my thoughts then ! |
Contributor
Author
|
@isekovanic all good, there's no rush! I can take a look at the v10 part when it gets through, unless you want it against that feature branch to start |
Contributor
|
No no, that's okay - I'll anyway need some time to look through it properly which I likely won't be able to do until tomorrow. I'll let you know ! Thanks a bunch 🚀 |
1 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Offer an opt-in native Expo UI attachment picker for downstream Expo apps while preserving the Gorhom picker as the SDK default. This integration targets iOS and Android; web is out of scope.
🛠 Implementation details
stream-chat-expo/attachment-picker, keeping@expo/uian optional peer isolated from the main SDK entry point.EXPO_PUBLIC_ATTACHMENT_PICKER=gorhomto compare the default picker.🎨 UI Changes
The opt-in picker uses the native Expo UI modal sheet with an explicit Close action. Gorhom remains unchanged for apps that do not opt in.
Before/after iOS and Android screenshots or recordings still need to be attached.
🧪 Testing
☑️ Checklist
developbranchNo Linear ticket is currently associated with this fork contribution; coordinate with the Stream team before opening under the repository's ticket requirement.