Repository navigation
fix(pi): support OMP RPC protocol v2 chunked frames and add model refresh button - #95
Merged
Merged
Conversation
…resh button OMP v19+ caps RPC protocol v1 frames at 1 MiB, so environments with large model catalogs (such as OpenRouter) fail get_available_models with 'RPC response exceeded the transport limit'. Negotiate protocol v2 when advertised on ready, reassemble rpc_chunk frames, and retry pre-ready overflowed requests once v2 is active. Also add a 'Refresh models' button to the Models section header on the provider config page, calling server.refreshProviders for that instance with refreshModels: true.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ompv19+ exposes a large model catalog (for example viaOPENROUTER_API_KEY, ~528 models / 1.42 MiB JSON),get_available_modelsexceedsomp's 1 MiB RPC protocol v1 frame limit and fails with"RPC response exceeded the transport limit", leaving the provider stuck with"Pi is available, but T3 Code could not refresh its models and commands".Fix
negotiate_protocol) inpackages/provider-pi/src/server/rpc.tswhenreadyadvertisessupportedProtocolVersionscontaining2, reassemblerpc_chunkbase64 frames up to 64 MiB, and retry a pre-readyrequest once if it fails with"RPC response exceeded the transport limit"before v2 completes.ProviderInstanceCard/ProviderSettingsPanelthat callsserver.refreshProviderswith{ instanceId, refreshModels: true }, with translated copy across all web locales.docs/adr/0031-pi-rpc-protocol-v2-chunked-frames.mdanddocs/adr/0032-provider-models-refresh-button.md.Verification
vp run check:changed: format, lint, knip, typecheck (9 packages), react compiler, and all 192 non-browser unit tests passed (browser tests rely on CI Playwright).vp run i18n:check: passed across web, mobile, and desktop catalogs.checkPiProviderStatusagainst localompv19.0.0: returnedstatus: "ready",message: null, and 532 models.Done with
loem/gemini-4-neonin OpenCode.