Repository navigation
fix: raise errors for non-2xx Static Maps responses - #16
Draft
illuminati1911 wants to merge 1 commit into
Draft
illuminati1911 wants to merge 1 commit into
illuminati1911 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing Static Maps response handler exposes error bodies as image bytes because it bypasses normal HTTP-status validation.
HTTPErrorwith the original status.Fixes googlemaps#447. Related prior work: googlemaps#446.
Verification
Python 3.10.20 with Requests 2.34.2:
Regression coverage.
Verification limits
Python 3.5 and 3.7 are unavailable; the full multi-version CI matrix was not run. The documentation build used Python 3.10 rather than the configured Python 3.7. No Python support minimum changed. Existing setuptools packaging deprecation warnings remain.