Repository navigation
feat(valgrind): add --experimental-rep-bulk-cost flag - #620
not-matthias wants to merge 1 commit into
Conversation
235d1d4 to
f4a85b0
Compare
Merging this PR will not alter performance2 warnings
Comparing Footnotes
|
[Medium impact] The change reaches benchmark runs that opt into the new Callgrind cost model. The code changes appear safe to merge once the already acknowledged Valgrind release prerequisite is satisfied; the test suggestion is non-blocking.
|
f4a85b0 to
fac7a1b
Compare
Adds an opt-in
--experimental-rep-bulk-costflag (envCODSPEED_EXPERIMENTAL_REP_BULK_COST). When set together with--cycle-estimation, the runner passes--rep-bulk-cost=yesto Callgrind, which prices amd64rep movs/rep stosfrom a calibrated bulk cost curve instead of the per-element model.The option is off by default in valgrind-codspeed, so default results are unchanged. Once we are happy with the results, the runner can turn it on by default.
Depends on CodSpeedHQ/valgrind-codspeed#60. Requires a valgrind-codspeed release containing it and a bump of
VALGRIND_CODSPEED_ITERATIONbefore merging: older valgrind builds reject the unknown option.Closes COD-4199