STL codec: should use binary file format #29

Activity

1. jmwright commented on Feb 10, 2024

   

   jmwright

   on Feb 10, 2024

   Member

   More actions

   We'll need to figure out how to add this option. For formats like gltf you can determine whether a binary or ASCII version is desired based on the file extension, but with STL that is not possible since the same file extension is used for both. Maybe there could be an --encoding command line parameter that accepts binary, ASCII, utf-8 etc, which is then passed through to the codec, which can decide how to use that information.
2. drayde commented on Feb 10, 2024

   

   drayde

   on Feb 10, 2024

   ContributorAuthor

   More actions

   I would opt for always saving binary STLs in a first step, as in most use cases this is what you would want
3. jmwright commented on Feb 10, 2024

   

   jmwright

   on Feb 10, 2024

   Member

   More actions

   Arguments for keeping ASCII as the default, or at least giving the user the option to revert back to ASCII.

   1. Defaulting to binary would change existing behavior and could break existing systems that integrate cq-cli if they upgrade.
   2. When CQ changed from ASCII to binary as the default for STL, it broke some things downstream. Nothing major, but it did cause some confusion.
   3. cq-cli is designed to be used in pipelines for text transformations as well, which would be broken if defaulting to binary without a way to revert to ASCII.

   👍React with 👍1Reacted by Andreas Kahler