Repository navigation
signer: Prevent state rollback across restarts - #769
Draft
ihordiachenko wants to merge 4 commits into
Draft
ihordiachenko wants to merge 4 commits into
ihordiachenko wants to merge 4 commits into
Conversation
The node advances its delta baseline when it sends a request. A signer that discards a rejected request must reconnect to receive a full snapshot. Back off before reconnecting to a node that keeps failing.
A synced file can still be lost if the directory that contains it was just created. Sync the parent when creating a storage directory on Unix.
Check the startup snapshot against the last committed versions and value hashes before restoring VLS state. Save the watermark before returning signatures and stop the signer when a snapshot violates it. Require complete node records, preserve signed tombstones, and restore the VLS channel ID high-water mark while allowing retries for existing channels.
ihordiachenko
force-pushed
the
fix/924-state-watermark
branch
from
November 18, 2026 22:45
4883996 to
28e2e10
Compare
Make callers supply durable storage for production signers. Thread the storage path through the bindings, CLIs, examples and test fixtures. Reuse the signer and its loaded device state when applying credentials after registration, recovery or standalone authentication.
ihordiachenko
force-pushed
the
fix/924-state-watermark
branch
from
November 18, 2026 23:24
28e2e10 to
694d77a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs GL #924. Depends on PR #766 for Hard mode and device storage.
After a restart, a signer can receive an older or incomplete snapshot whose entries still have valid signatures. That can roll back signer state or cause missing channel state to be treated as new.
Use one active signing device per node. A lost response or conflicting writes from two devices can block restart until the node supplies state that satisfies the watermark.