Repository navigation
Erik/lsps discovery - #244
Merged
Merged
Conversation
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
from
August 29, 2023 11:56
cdc2a43 to
8dc477c
Compare
Randy808
reviewed
Aug 30, 2023
Randy808
reviewed
Aug 30, 2023
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
3 times, most recently
from
August 31, 2023 13:09
16132d9 to
cf21516
Compare
ErikDeSmedt
marked this pull request as draft
September 1, 2023 08:11
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
from
September 1, 2023 08:24
cf21516 to
4d058b7
Compare
Collaborator
Author
|
I managed to fix the permission issue on the plugin. The current idea is. Locally we mount our repo. In this case, we lose the permission change we've set when building our Docker-image. |
ErikDeSmedt
marked this pull request as ready for review
September 1, 2023 10:17
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
from
September 1, 2023 10:18
4d058b7 to
aa3afb5
Compare
cdecker
previously requested changes
Sep 11, 2023
cdecker
marked this pull request as draft
September 11, 2023 12:35
cdecker
marked this pull request as ready for review
September 11, 2023 12:35
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
8 times, most recently
from
September 14, 2023 11:23
08cc17c to
0560cca
Compare
cdecker
force-pushed
the
erik/lsps-discovery
branch
from
September 14, 2023 14:25
0560cca to
7e0b238
Compare
cdecker
enabled auto-merge (rebase)
September 18, 2023 10:24
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
from
September 20, 2023 11:45
7e0b238 to
e23b54b
Compare
Collaborator
Author
|
I rebased on latest tip of main 1aa4335 |
ErikDeSmedt
force-pushed
the
erik/lsps-discovery
branch
from
September 21, 2023 13:38
e23b54b to
7cd5ac6
Compare
This is more descriptive of the purpose of the change
See previous commit. I did as 2 commits to ensure git recognized that `transport.rs` is renamed to `client.rs`
Implement `list_lsp_servers`
Implemented language bindings for list_lsp_servers and created an integration test. The integration test uses a dummy-plugin which makes our test-nodes appear as if they are Lightning Service Providirs.
Moved the `to_bitmap` function to the `test`-module to surpress unused code warnings.
Thanks Randy for finding this out in code-review
This method did become obsolete. Initially, it was used to ensure our methods could accept both a node_id both as a python `bytes`-object or as a hex-encoded string. We are now using the hex-encoded string consistently
Created the correct rights in github actions Forced to `libs/gl-testing/tests/util/dummy_lsps_plugin.py` to have execute permissions
See comments from `fundchannel` Remove spurious clone in list_lsp_servers Code review comments from christian
cdecker
force-pushed
the
erik/lsps-discovery
branch
from
September 25, 2023 16:11
d99deb2 to
377ff82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation + tests for discovery of Lightning Service Providers.
I refactored a little bit. I have removed the
Transprortwhich could be used for to send JSON-rpc messages and have created anLspClientinstead.