Skip to content

Erik/lsps discovery - #244

Merged
cdecker merged 12 commits into
Blockstream:mainfrom
ErikDeSmedt:erik/lsps-discovery
Sep 27, 2023
Merged

cdecker merged 12 commits into
Blockstream:mainfrom
ErikDeSmedt:erik/lsps-discovery

Conversation

@ErikDeSmedt

Copy link
Copy Markdown
Collaborator

Implementation + tests for discovery of Lightning Service Providers.

I refactored a little bit. I have removed the Transprort which could be used for to send JSON-rpc messages and have created an LspClient instead.

Comment thread libs/gl-client-py/glclient/lsps.py Resolved
Comment thread libs/gl-client-py/glclient/lsps.py Resolved
@ErikDeSmedt
ErikDeSmedt force-pushed the erik/lsps-discovery branch 3 times, most recently from 16132d9 to cf21516 Compare August 31, 2023 13:09
@ErikDeSmedt
ErikDeSmedt marked this pull request as draft September 1, 2023 08:11
@ErikDeSmedt

Copy link
Copy Markdown
Collaborator Author

I managed to fix the permission issue on the plugin.

The current idea is.
In CI the plugin is made executable in the Dockerfile. Once we are in the image we cannot change the permissions anymore.

Locally we mount our repo. In this case, we lose the permission change we've set when building our Docker-image.
Therefore, we have a fixture that sets the permission if needed.

@ErikDeSmedt
ErikDeSmedt marked this pull request as ready for review September 1, 2023 10:17
Comment thread libs/gl-client/src/lsps/client.rs Resolved
Comment thread libs/gl-client/src/lsps/client.rs Resolved
Comment thread libs/gl-testing/tests/test_lsps.py Resolved
Comment thread libs/gl-testing/tests/test_lsps.py Resolved
@cdecker
cdecker marked this pull request as draft September 11, 2023 12:35
@cdecker
cdecker marked this pull request as ready for review September 11, 2023 12:35
@ErikDeSmedt ErikDeSmedt mentioned this pull request Sep 11, 2023
10 tasks
@ErikDeSmedt
ErikDeSmedt force-pushed the erik/lsps-discovery branch 8 times, most recently from 08cc17c to 0560cca Compare September 14, 2023 11:23
@cdecker
cdecker force-pushed the erik/lsps-discovery branch from 0560cca to 7e0b238 Compare September 14, 2023 14:25
@cdecker
cdecker enabled auto-merge (rebase) September 18, 2023 10:24
@ErikDeSmedt

Copy link
Copy Markdown
Collaborator Author

I rebased on latest tip of main 1aa4335

This is more descriptive of the purpose of the change
See previous commit.
I did as 2 commits to ensure git recognized that
`transport.rs` is renamed to `client.rs`
Implemented language bindings for list_lsp_servers and created an
integration test.

The integration test uses a dummy-plugin which makes our test-nodes
appear as if they are Lightning Service Providirs.
Moved the `to_bitmap` function to the `test`-module to surpress unused
code warnings.
Thanks Randy for finding this out in code-review
This method did become obsolete.

Initially, it was used to ensure our methods could accept both a node_id
both as a python `bytes`-object or as a hex-encoded string.

We are now using the hex-encoded string consistently
Created the correct rights in github actions
Forced to `libs/gl-testing/tests/util/dummy_lsps_plugin.py` to have
execute permissions
See comments from `fundchannel`

Remove spurious clone in list_lsp_servers

Code review comments from christian
@cdecker
cdecker force-pushed the erik/lsps-discovery branch from d99deb2 to 377ff82 Compare September 25, 2023 16:11
@cdecker
cdecker dismissed their stale review September 25, 2023 16:12

Addressed

@cdecker
cdecker merged commit b8f69e7 into Blockstream:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants