Repository navigation
Conversation
When CONFIG_SILENT_CONSOLE is enabled and GD_FLG_SILENT is set (e.g. via the 'silent' environment variable), console_announce_r() previously called console_puts_select() unconditionally, printing the startup banner to the video console regardless of the silent console setting. Check GD_FLG_SILENT before outputting the banner so systems configured with a silent console (such as splash-screen boots) remain silent. Signed-off-by: Marcelo Alcantara <maralc@gmail.com> Signed-off-by: kleinbem <martin.kleinberger@gmail.com>
kleinbem
force-pushed
the
feat/silent-console-banner
branch
from
November 13, 2026 09:37
db3254d to
b1826f6
Compare
kleinbem
marked this pull request as ready for review
November 13, 2026 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
CONFIG_SILENT_CONSOLEis enabled andGD_FLG_SILENTis active ingd->flags(for example via thesilentenvironment variable),console_announce_r()previously bypassed the silence check and calledconsole_puts_select(stdout, false, buf)unconditionally. Becauseconsole_puts_select()outputs directly to stdio device callbacks without checkinggd->flags, the U-Boot banner was displayed on the video console even when silent mode was explicitly configured.This commit adds a check for
IS_ENABLED(CONFIG_SILENT_CONSOLE) && (gd->flags & GD_FLG_SILENT)at the entry ofconsole_announce_r(), keeping the console completely silent when requested (e.g. for silent splash-screen boots).Signed-off-by: Marcelo Alcantara maralc@gmail.com
Signed-off-by: kleinbem martin.kleinberger@gmail.com