Repository navigation
fix(plugins): harden plugin pages and markdown preview - #3036
smithjack11 wants to merge 3 commits into
Conversation
[Medium impact] The PR appears safe to merge, with a non-blocking issue when linked-file opens fail or are cancelled. Findings
SummaryThe PR hardens plugin pages and Markdown previews.
No numbered previous comments were supplied. Their threads remain review context. Reviews (2) · Last reviewed commit: "fix: strengthen markdown KaTeX marker en..." · Reviewed by Greptile |
| event.stopPropagation(); | ||
| try { | ||
| await openFile(path); | ||
| onOpen?.(); |
There was a problem hiding this comment.
Cancelled links close the page
onOpen hides the plugin page even when no linked file opened. openFile(path) returns normally when the user declines the binary-file prompt, and it catches file errors without rethrowing them. The new callback therefore closes the page after cancellation or failure, forcing users to reopen it to continue reading. Check that the file actually opened before calling onOpen.
Summary
c++/c#code fences.Verification
node --checkpasses for the changed Markdown preview files and test.git diff --checkpasses.node_modulesis absent.Related: #3034 (separate preview CORS fix).