From 9adbe19c18aca819d713b98aa24f1b064f6fd2c7 Mon Sep 17 00:00:00 2001 From: jipeng6036-del <241105014+jipeng6036-del@users.noreply.github.com> Date: Wed, 18 Nov 2026 10:21:13 -0800 Subject: [PATCH] Report registered components in Fantom view manager queries --- .../__tests__/HasViewManagerConfig-itest.js | 36 +++++++++++++++++ .../tester/src/TesterMountingManager.cpp | 11 ++++++ .../tester/src/TesterMountingManager.h | 1 + .../src/stubs/StubComponentRegistryFactory.h | 39 ++++++++++++------- 4 files changed, 72 insertions(+), 15 deletions(-) create mode 100644 packages/react-native/Libraries/ReactNative/__tests__/HasViewManagerConfig-itest.js diff --git a/packages/react-native/Libraries/ReactNative/__tests__/HasViewManagerConfig-itest.js b/packages/react-native/Libraries/ReactNative/__tests__/HasViewManagerConfig-itest.js new file mode 100644 index 000000000000..0cabedfd0e96 --- /dev/null +++ b/packages/react-native/Libraries/ReactNative/__tests__/HasViewManagerConfig-itest.js @@ -0,0 +1,36 @@ +/** + * Copyright (c) Meta Platforms, Inc. and affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * + * @flow strict-local + * @format + */ + +import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment'; + +import * as Fantom from '@react-native/fantom'; +import * as React from 'react'; +import {UIManager, View} from 'react-native'; + +describe('UIManager.hasViewManagerConfig in Fantom', () => { + it('recognizes components registered by the tester', () => { + const root = Fantom.createRoot(); + Fantom.runTask(() => { + root.render(); + }); + expect(root.getRenderedOutput().toJSX()).toEqual( + , + ); + + expect(UIManager.hasViewManagerConfig('View')).toBe(true); + expect(UIManager.hasViewManagerConfig('RCTView')).toBe(true); + }); + + it('returns false for an unregistered component', () => { + expect(UIManager.hasViewManagerConfig('UnregisteredFantomTestView')).toBe( + false, + ); + }); +}); diff --git a/private/react-native-fantom/tester/src/TesterMountingManager.cpp b/private/react-native-fantom/tester/src/TesterMountingManager.cpp index ae79e5f1f4a4..59e963c7b514 100644 --- a/private/react-native-fantom/tester/src/TesterMountingManager.cpp +++ b/private/react-native-fantom/tester/src/TesterMountingManager.cpp @@ -9,9 +9,11 @@ #include "stubs/StubComponentRegistryFactory.h" #include +#include #include #include #include +#include namespace facebook::react { @@ -121,6 +123,15 @@ ComponentRegistryFactory TesterMountingManager::getComponentRegistryFactory() { return getDefaultComponentRegistryFactory(textLayoutManager_); } +bool TesterMountingManager::hasComponent(const std::string& name) { + const auto componentName = componentNameByReactViewName(name); + return std::ranges::any_of( + getFantomComponentDescriptorProviders(), + [&componentName](const auto& provider) { + return componentName == provider.name; + }); +} + StubViewTree TesterMountingManager::getViewTree(SurfaceId surfaceId) { if (viewTrees_.find(surfaceId) == viewTrees_.end()) { LOG(ERROR) diff --git a/private/react-native-fantom/tester/src/TesterMountingManager.h b/private/react-native-fantom/tester/src/TesterMountingManager.h index b8a8e506c178..ba345709f50a 100644 --- a/private/react-native-fantom/tester/src/TesterMountingManager.h +++ b/private/react-native-fantom/tester/src/TesterMountingManager.h @@ -34,6 +34,7 @@ class TesterMountingManager : public IMountingManager { void onUpdateShadowTree(const std::unordered_map &tagToProps) override; ComponentRegistryFactory getComponentRegistryFactory() override; + bool hasComponent(const std::string &name) override; std::vector takeMountingLogs(SurfaceId surfaceId); diff --git a/private/react-native-fantom/tester/src/stubs/StubComponentRegistryFactory.h b/private/react-native-fantom/tester/src/stubs/StubComponentRegistryFactory.h index d4ccd0ec8ed6..6eca3b973001 100644 --- a/private/react-native-fantom/tester/src/stubs/StubComponentRegistryFactory.h +++ b/private/react-native-fantom/tester/src/stubs/StubComponentRegistryFactory.h @@ -9,6 +9,8 @@ #include "FantomTextInput.h" +#include + #include #include #include @@ -23,6 +25,25 @@ namespace facebook::react { +inline const auto &getFantomComponentDescriptorProviders() +{ + static const std::array providers{ + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider(), + concreteComponentDescriptorProvider>(), + concreteComponentDescriptorProvider>(), + concreteComponentDescriptorProvider>(), + }; + return providers; +} + inline ComponentRegistryFactory getDefaultComponentRegistryFactory(std::shared_ptr textLayoutManager) { return [textLayoutManager = std::move(textLayoutManager)]( @@ -31,21 +52,9 @@ inline ComponentRegistryFactory getDefaultComponentRegistryFactory(std::shared_p contextContainer->insert("TextLayoutManager", textLayoutManager); static const auto providerRegistry = []() { auto providerRegistry = std::make_shared(); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add(concreteComponentDescriptorProvider()); - providerRegistry->add( - concreteComponentDescriptorProvider>()); - providerRegistry->add( - concreteComponentDescriptorProvider>()); - providerRegistry->add( - concreteComponentDescriptorProvider>()); + for (const auto &provider : getFantomComponentDescriptorProviders()) { + providerRegistry->add(provider); + } return providerRegistry; }(); return providerRegistry->createComponentDescriptorRegistry(