[mokevnin]

JobListParams has Where(sql, NamedArgs) for predicates its filters can't express, but JobDeleteManyParams doesn't. We need to delete queued jobs by a value in their args: when erasing a customer's personal data (GDPR), every non-running job whose args name that customer has to go, in the same transaction as the erasure. Today that means listing the jobs first and deleting them by ID, or going around River to the river_job table, which we'd rather not do.

This adds JobDeleteManyParams.Where(sql string, namedArgs ...NamedArgs), mirroring JobListParams.Where and built on the same dblist path, so it works with every driver:

client.JobDeleteManyTx(ctx, tx, river.NewJobDeleteManyParams().
    Kinds("send_email").
    Where("(args->>'customer_id')::bigint = any(@ids)", river.NamedArgs{"ids": ids}))

Two details:

• A Where predicate counts as a filter, so params with only a Where don't need UnsafeAll (and calling UnsafeAll after Where panics, like after any other filter).
• Unlike the list version, each delete predicate is wrapped in parentheses. JobDeleteMany appends its state != 'running' guard with AND, so an unparenthesized OR would widen the deletion past the other filters and to running jobs. The closing parenthesis goes on its own line so a trailing -- comment in the predicate can't comment it out.

Named args are merged into a fresh map, so the caller's maps aren't modified.

The other ports have no raw predicate on their list either, so this is Go-only, like JobListParams.Where.

Tests

• delete_many_params_test.go: Where counts for filtersEmpty and makes UnsafeAll panic; the generated where clause wraps each predicate (including one with a trailing comment); named args merge without mutating the caller's maps; the receiver isn't modified.
• client_test.go (Test_Client_JobDeleteMany): deleting by args->>'customer_id' together with Kinds; a Where alone without UnsafeAll; and an OR predicate that must not delete a running job or a job of another kind. That last test fails with the parentheses removed (it then deletes all three jobs).
• The driver suite in riverdriver/riverdrivertest/job_delete.go already covers JobDeleteMany with a raw WhereClause and named args on every driver.

🤖 Generated with Claude Code

[brandur]

Thanks @mokevnin! Do you think you could sign our https://github.com/riverqueue/rivercla? I'll take a look at this in a bit.

[mokevnin]

Thanks @brandur! Signed the CLA in riverqueue/rivercla#41.

[brandur]

Ty!

Pushed one more commit here with:

• A few more delete-related tests that gets some edges like predicates, OR safety, and trailing comments.
• Docs that mention batch limits and skipped locked jobs.
• Alphabetized some functions and test cases according to project convention.

[brandur]

Released v0.51.0