Skip to content

Fix flaky galata visual-regression tests: wait for render + pixel tol… - #1708

Merged
ChakriCherukuri merged 2 commits into
masterfrom
fix-flaky-galata-tests
Oct 8, 2026
Merged

ChakriCherukuri merged 2 commits into
masterfrom
fix-flaky-galata-tests

Conversation

@ChakriCherukuri

Copy link
Copy Markdown
Member

References

Fixes the flaky visual-regression-tests (bars.ipynb light/dark, cell-1) seen on recent PRs.
Related: #1674, #1639.

Code changes

The visual tests captured each cell's screenshot immediately in onAfterCellRun, before
bqplot's async SVG draw finished — racing the render and producing ~1% pixel jitter
(concentrated on tick-label text). This waits for svg.svg-figure + document.fonts.ready

  • a short settle before capturing, and adds maxDiffPixelRatio: 0.02 as a safety net for
    residual anti-aliasing noise. Applied to both the first-render and update-plot test paths.
    No library/source changes; no snapshot changes.

User-facing changes

None.

Backwards-incompatible changes

None.

@ChakriCherukuri

Copy link
Copy Markdown
Member Author

please update snapshots

@ChakriCherukuri
ChakriCherukuri merged commit 74a53db into master Oct 8, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant